This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
dr3
changed the title
Create initial psammead-image
Migrate Image component from Simorgh
Dec 18, 2018
ChrisBAshton
suggested changes
Dec 18, 2018
Co-Authored-By: dr3 <drew.mcmillan@bbc.co.uk>
ChrisBAshton
previously approved these changes
Dec 18, 2018
bcmn
reviewed
Dec 18, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple wording suggestions.
Co-Authored-By: dr3 <drew.mcmillan@bbc.co.uk>
Co-Authored-By: dr3 <drew.mcmillan@bbc.co.uk>
bcmn
previously approved these changes
Dec 18, 2018
ChrisBAshton
previously approved these changes
Dec 18, 2018
sareh
previously requested changes
Dec 18, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:
sareh
reviewed
Dec 18, 2018
ChrisBAshton
previously approved these changes
Dec 18, 2018
radiocontrolled
previously requested changes
Dec 18, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny change to the readme requested for consistency.
ChrisBAshton
approved these changes
Dec 18, 2018
sareh
approved these changes
Dec 18, 2018
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #203
Create initial psammead-image